For #6687: Add crash reporting information for ClassCastException in PromptFeature #6995
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6995 +/- ##
============================================
+ Coverage 76.85% 77.07% +0.22%
- Complexity 4739 4832 +93
============================================
Files 647 642 -5
Lines 23622 23645 +23
Branches 3453 3446 -7
============================================
+ Hits 18154 18224 +70
+ Misses 4020 3970 -50
- Partials 1448 1451 +3
Continue to review full report at Codecov.
|
| Breadcrumb.Level.DEBUG, Breadcrumb.Type.NAVIGATION) | ||
| ) | ||
|
|
||
| crashReporting?.submitCaughtException(e) |
There was a problem hiding this comment.
I don't really like the idea of catching ClassCastException here every time since it will just hide errors while developing. Maybe we could just consider adding regular breadcrumbs to the feature (showing prompt, confirming, cancelling) that are helpful for understanding all kinds of errors?
There was a problem hiding this comment.
Sure, I'll add breadcrumb and throw the exception after.
There was a problem hiding this comment.
Oh, I was thinking about just generic breadcrumbs independent of the exception here.
But talking about the exception. Maybe you do not want a breadcrumb and instead just rethrow a new exception with a better message (and the original one as cause)?
There was a problem hiding this comment.
I am worried this is called too many times to add a generic breadcrumb without an exception. Sure, I could modify the message. But wouldn't that be similar to adding a breadcrumb since we will be try catching the exception and rethrowing?
rocketsroger
force-pushed
the
AC_6687
branch
2 times, most recently
from
45c17f8 to
01b9aac
Compare
…tException in PromptFeature
|
bors r=pocmo |
|
Build succeeded: |
Pull Request checklist
After merge